Michael B Kuhn
Michael B Kuhn
With documentation now added, I think that the only thing remaining is unit tests.
@gdeskos I'd like you to try this out before it gets merged. @marchdf can glance over the code as well. The unit testing in AMR-Wind is limited because the Waves2AMR...
I plan to deprecate the ocean_waves/HOSWaves.cpp capability in a separate PR after this one gets merged. FYI Phil already merged the necessary changes for this to compile with spack-manager.
@ET14 great job getting this set up! I've added a few commits for the sake of passing the CI tests and correcting a print statement. If there are more changes...
@ET14 @tonyinme I will try to get this polished up for merging soon. I'll be making direct edits to the branch, but feel free to make comments on my work.
> @tonyinme do we want to generalize the options to > > * disable certain force components > > * calculate the actuator force with the freestream velocity magnitude >...
@ET14 I believe I have generalized the capabilities from your work. I put a new reg test in test/test_files/act_pitching_wing_2D that should serve as an example for the input arguments. Please...
reg tests passed. last thing is unit tests
requested changes addressed
This is a helpful discussion, and it points to a need for having a more complete implementation in the future, one that uses time- and space-varying force data. However, for...