amr-wind icon indicating copy to clipboard operation
amr-wind copied to clipboard

Adding Waves2AMR library

Open mbkuhn opened this issue 1 year ago • 7 comments

  • big development for ocean wave initialization and forcing

mbkuhn avatar Aug 18 '23 17:08 mbkuhn

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Oct 02 '23 02:10 github-actions[bot]

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Nov 02 '23 02:11 github-actions[bot]

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Dec 07 '23 02:12 github-actions[bot]

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Jan 07 '24 02:01 github-actions[bot]

@gdeskos I'd like you to try this out before it gets merged. @marchdf can glance over the code as well. The unit testing in AMR-Wind is limited because the Waves2AMR features have unit tests within the Waves2AMR repo.

mbkuhn avatar Feb 12 '24 15:02 mbkuhn

I plan to deprecate the ocean_waves/HOSWaves.cpp capability in a separate PR after this one gets merged. FYI Phil already merged the necessary changes for this to compile with spack-manager.

mbkuhn avatar Feb 12 '24 15:02 mbkuhn

@mbkuhn , I can confirm that this works well when coupled to ABL simulations. As an example, here is an image of the waves in a 9km by 9km simulation from the test we did a few days ago.

Screenshot 2024-03-12 at 7 59 55 PM

tonyinme avatar Mar 13 '24 02:03 tonyinme

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Apr 26 '24 02:04 github-actions[bot]