Marnik Bercx

Results 304 comments of Marnik Bercx
trafficstars

As @superstar54 knows, I'm a big fan of having nicer representations in Jupyter notebooks, visualising the structure when a `StructureData` is returned (as I think he already implemented: https://github.com/aiidateam/aiida-atomistic/pull/18), or...

As mentioned, there are a bunch of fixtures in `aiida-quantumespresso` that should probably be in `aiida-core`, see https://github.com/aiidateam/aiida-quantumespresso/issues/1101. I was keen on working on this, but right now it isn't...

Hmm, that reminds me of this beast of a PR that I never got finalised: https://github.com/aiidateam/aiida-quantumespresso/pull/749 I'm not sure if I fix this issue there. Let me have a look...

The logic does seem to be there: https://github.com/mbercx/aiida-quantumespresso/blob/1231976936682ae7cc9ca38da66b68bc8189e531/aiida_quantumespresso/parsers/projwfc.py#L343-L352 I still vaguely remember being very confused about the structure of these PDOS files in Quantum ESPRESSO though. 😅 Going to see...