Marnik Bercx
Marnik Bercx
@sphuber ok, I refactored my initial refactor quite a bit, so perhaps this needs a full review again, apologies. It was also quite a bit of work to fix all...
Because of the size of the PR, and the fact that even though the tests pasts it can definitely break things, perhaps: * @PNOGillespie @superstar54 maybe you can have a...
Great, thanks @PNOGillespie and @qiaojunfeng! I guess now she just needs a proper review, @sphuber. 😉
> @mbercx did you want to get this merged before the release? If so, is there anything to be done from your side? Otherwise I will approve. We can deal...
@sphuber it seems the autoapi extension doesn't always play nice with type hints. To avoid going down this rabbit hole here, I simply added the problematic classes to `nitpick_ignore`. I'll...
> want to finish that one up and release it? Yessir! Sorry for the slow response. > There were API changes, as far as I can see. The internal parsing...
> However, it depends on how closely you want to follow the semantic versioning principles. Yeah, that's fair. Perhaps we should be clearer in defining the public API. I don't...
> Power users can always modify the builder directly if needed. Just came back to this issue and wanted to note that in my setup I rely heavily on `overrides`...
It took a lot of tweaking, but I think the PR is now _very_ close to being finalised. I think the most work now is to write a proper commit...
@mkotiuga I've updated the title and OP to what I think the commit header and message should be. Have a look and let me know if you have any comments!