Marnik Bercx

Results 304 comments of Marnik Bercx
trafficstars

> The fix for this feature request would not touch the PwCalculation though. Since it is the PwBaseWorkChain that would have to merge the trajectories, all the change in code...

> I don't see how that would even be possible. The PwParser won't have access to the outputs of the previous calculation, so how can it merge. Haha, I'm clearly...

One idea would be to add a tool to the `PwRelaxWorkchain` in the `tools` namespace that merges the output trajectory. @sphuber is there any reason why we wouldn't extend this...

> No, I don't see a reason why not. The code in aiida-core is straightforward, so adding it should be simple. Great! Ideally a `BaseRestartWorkChain` would also have a `tools`...

@sphuber as discussed, I've written a bunch of tests to check the edge cases I've been studying, first based on the latest release tag (v2.5.1): https://github.com/mbercx/aiida-core/blob/test/upload-calc/tests/engine/daemon/test_execmanager.py These should all pass...

Ok, I've extended the number of tests, added tests for the SSH transport, and managed to get it down to one failure (for SSH): https://github.com/mbercx/aiida-core/actions/runs/9345893736/job/25719640192 See all changes here: https://github.com/mbercx/aiida-core/commit/fa0e9c5fc175e8d7cff34da6705fb80f1673d6b8...

Thanks @sphuber! Unfortunately, the `.errno` attribute of the exception that is raised seems to be `None`... Instead I've added a check to see if the parent destination directory exists in...

Also double-checked my branch adding these tests on v2.5.1, and can confirm they all pass, save for the same error [discussed above](https://github.com/aiidateam/aiida-core/pull/6348#issuecomment-2144677658).

My suggestion for proceeding is to split up the PR in 3 commits: 1. `SshTransport`: Return `FileNotFoundError` if destination parent does not exist 2. Transports: overwrite existing folders if `overwrite...

+1. I started using the extension since editing on the web portal is blocked when my connection is intermittent (e.g. on the train). I guess I'll go back to just...