Michael Baudis
Michael Baudis
@mcourtot Exactly. The current "reads" defined (implied) structure assumes this. And even for `Experiment`s resulting in reads, most API implementations will query variants (but may need assay metadata, from `Experiment`...
... but @david4096's suggestion (`experiment_id` instead of embedded `experiment`) provides an easy structural fix. So: - Experiment.biosample_id - Reads.experiment_id - Variants.analysis_id ???
Both `Experiment` & `Analysis` had not been defined in a comprehensible manner. In my reading: - `Experiment` represents the procedures applied to an aliquot of a `Biosample` (e.g. library prep,...
@david4096 Yes; `Experiment`s, `Analysis`(es) are objects to tackle, and fortunately not really loaded yet (just disregard what is in there).
@david4096 @kozbo @dzerbino @mcourtot Bump for the Experiment/Analysis discussion. I can't follow the decision to remove `assay_metadata.proto` & put `Experiment`, `Analysis` into common. There was a lengthy discussion involving @dzerbino...
Generally: ``` // A Biosample refers to a unit of biological material from which the substrate // molecules (e.g. genomic DNA, RNA, proteins) for molecular analyses (e.g. // sequencing, array...
I understand the concept but not the inline description (referring to handovers)? Also the naming is a bit strange. `PrecisionCount` ==> `Precision` IMO `rounded` ==> `imprecise` Something like `imprecise` had...
See changes in https://github.com/ga4gh-beacon/beacon-v2/pull/223
I'm with @gsfk here - "rounded" is just the wrong word; it doesn't have to be rounded - could be randomized, shuffled etc. (rounded is specific and if really rounded...
@tb143 @zykonda Comments?