Michael Baudis
Michael Baudis
@datsirul Oh well, yes. I got confused by @redmitry `╮(╯▽╰)╭` because this was the issue in another discussion (the lists of lists in `examples` where this would be the case)....
@jordi @datsirul While in principle it is great to spot & correct this, the overarching question we had previously was about maintaining the OpenAPI documents at all. In the Ascona...
That is valid YAML and preferable over mixing indented lists and bracket annotations (there is an argument to be made for added newlines for new levels but YMMV). +1 for...
@datsirul @redmitry (Deleted earlier comment because not the right place for "kill OpenAPI" discussions here) Oh well, for now it is probably best to fix the examples to the OpenAPI...
@costero-e I have committed the fixes to thew `schema-urgent-fixes` branch * https://github.com/ga4gh-beacon/beacon-v2/commit/971a2adb46c2c6a7706d58e1493c06108c049e06 * https://github.com/ga4gh-beacon/beacon-v2/commit/33d22289f1c6355be8014d545abe02b4b0cee58e Please clean up :-)
@tb143 A technical comment: Please use the YAML version in source as reference :-)
General comments: * All 3 definitions of > @mbaudis are they different? In readability ... And, procedurally, changes should be edited in the `src` /` `.yaml` version and then converted...
One main issue is to clarify/understand the 3 different filter definitions: 1. In [`framework/configuration`](https://github.com/ga4gh-beacon/beacon-v2/blob/main/framework/src/configuration/filteringTermsSchema.yaml): This is where the format of a filtering term object resides; I am not sure how...
Proposal: Delete [/configuration/filteringTermsSchema.yaml](https://github.com/ga4gh-beacon/beacon-v2/blob/main/framework/src/configuration/filteringTermsSchema.yamln) / [/configuration/filteringTermsSchema.json](https://github.com/ga4gh-beacon/beacon-v2/blob/main/framework/json/configuration/filteringTermsSchema.json) As @redmitry says - it is not used, anywhere. And in contrast to maps etc. it has the schema for the response defined elsewhere.
@david4096 I am in support of Experiment as separate end point, referenced from whatever other object through experiment_id. Otherwise `Analysis` would be difficult to implement, especially when considering resources not...