Mark Barnes comments

Repositories
Issues
Comments

Results 4 comments of


                                            Mark Barnes

DAEValidatorLibrary is built and linked against but not installed

I think you should keep the .so because DAEValidatorLibrary is intended to provide validation and coherency check services to any application, not just the one tool. It's analogous to an...

ExternalProject_Add() should probably be used to reference libxml and pcre since it seems to be the cmake way of doing this

No I haven't in this context.

OpenCOLLADA fails to build with GCC 6

Unfortunately, `signed char` and `unsigned char` and `char` are incompatible types. Changing this type could snowball into more compiler errors (with iostream especially). What is the reason for using `-1`...

OpenCOLLADA fails to build with GCC 6

Implicit conversion from signed char to either of the other types could cause compiler errors. if that's not happening then okay (wait and see I guess).