may ohta

Results 44 comments of may ohta

unit test for nbest predictions #146

Hi, Could you please give us your error log? The current version of `build_vocab.py` takes one required positional argument (config.yaml path), and three optional keyword arguments (--join, --random-subset, and --seed)....

@juliakreutzer As far as I understand, `#!/usr/bin/env python` enables the script call without `python` command, like ``` $ ./scripts/build_vocab.py config.yaml ``` (If I'm wrong, please correct me!) Do we want...

ok, then let's do that :)

@KashyapKishore which config file do you mean?

Hi @KashyapKishore, The structure of config file is thoroughly updated in v2.0, joey v1.0 config files are no more compatible with joey v2.0. For plaintext (one sentence per line) data,...

I close this for now. See https://github.com/joeynmt/joeynmt/pull/181. Please reopen it if you still have the problem.

- background: An empty line raises an error in sacrebleu. maybe need to skip empty lines before evaluation?? - If we remove empty lines internally, input line numbers and output...

@juliakreutzer > What do you think about just raising an assertion with a more informative error message? yes, that sounds reasonable. I'll write an error message, then. Currently, the error...

*Note:* the same assertion error can happen, when the model generate an empty string (i.e. special symbol only, such as ` + `). Need to handle this not only in...