may ohta
Hi @Darwin99-debug, Thank you for your comment! Actually, we have been working on this (DDP) for a while. You can see our progress in the [ddp branch](https://github.com/joeynmt/joeynmt/tree/ddp) (#225) Although it...
see #225
@mcognetta Thank you for reporting! I feel it's not a bug, but an expected behaviour. Actually, we initially introduced the `patience` parameter for the plateau scheduler only. https://github.com/joeynmt/joeynmt/blob/0968187ac0968007cabebed5e5cb6587c08dff78/configs/transformer_small.yaml#L98 The term...
I understand there is such a situation and would be nice. My concern is how essential the functionality is, though. You know, I also implement many small "nice-to-have"s, but keep...
Yes, open a PR, please! I'm more than happy for democratic decision. Honestly, I'm sometimes afraid that this project would have some bias towards my personal preferences. Always nice to...
@mcognetta Thank you for catching the error and the correction! You are right, we forgot to add the file existence check in subword-nmt class, and yes, it should be `self.codes.name`,...
Actually, I didn't face the error in my environment, the relative path worked nicely... I don't know why it happened to you. ... and I'm wondering why this assertion couldn't...
@mcognetta Now I think the problem was rather in `get_iwslt14_bpe.sh` script. Please have a look at https://github.com/joeynmt/joeynmt/compare/main...may-:joeynmt:dev And I also forgot to cast the codes file IO object to pathlib's...