Sam Lin

Results 171 comments of Sam Lin
trafficstars

Actually, I think I can still preserve modifyCachedHtml in ServeFromCacheConfig to avoid breaking change. But I think we have to add modifyGeneratedHtml in ISRHandlerConfig

I push a [commit ](https://github.com/maxisam/rx-angular/commit/c95d1c6d9f59f9708e0953f7b668e697894b50c3)to show the idea. I will test it more tomorrow but I think it should work. It does change a lot of code so feel free...

@eneajaho I basically finished this but there are comflicts because of my other PR haven't been merged. It is basically this [PR](https://github.com/rx-angular/rx-angular/pull/1776) I will push it again once other PRs...

https://github.com/hyperspike/valkey-operator i think someone is working on operator. It is a different solution tho.

i wonder if we add code like below and access this.rawCookie instead of this.document.cookie ```typescript get rawCookie(): string | undefined { if (this.documentIsAccessible) { return this.document.cookie; } else { const...

That is a good point. Do you think reverse this will solve this issue? If we have duplicated cookie, I think the response one will overwrite the request one in...

well, this will be @pavankjadda 's decide. Either way is fine with me, but i do think having one solution is probably better than having both.

I am not sure why, I think it works sometime but not always. But unfortunately, i don't have bandwidth to address this now.

related to #114