Sam Lin

Results 143 comments of Sam Lin
trafficstars

I have this issue on vs2019 with `GitHub for Visual Studio`

it was fine with `GitHub for Visual Studio` until I installed `Diff All Files`

So I check the code, it is a bug for sure https://github.com/aancw/markdownload/blob/82688b831b4e268fdf404d3a2cfccc82b713062e/src/background/background.js#L786 download image is false here, so it will never download images

same with this one https://github.com/deathau/markdownload/issues/129

workaround: use "local image plus"

I think it will be better to have a way to select options instead of typing. I think true / false is just one of them.

It seems like smtp.office365.com uses a different encryption called STARTTLS https://support.microsoft.com/en-us/office/pop-imap-and-smtp-settings-8361e398-8af4-4e97-b147-6c6c4ac95353 Not sure when I will have time to add this feature, welcome to make a PR

Thanks for all your feedback. I will try to get to them when I have time. Welcome to make a PR as well. validation step is just for testing the...

sorry, this is not in the scope right now. welcome to make a PR tho