Sam Lin

@eneajaho Thanks for the review, could you rerun the build?

> @maxisam A rebase is needed. Then we can merge 🎉 Do you mean you prefer to rewrite some commits and force push it? I usually don't do that since...

@eneajaho everything is green 🎉

I have no clue about the build error, might need you guys help on this Thx!

Thanks man, sorry about making so many changes. Your code base is really good and we have a similar thing I created for our company, so I hope we can...

also, I am on a camping trip with my family, so I might be slow to respond.

@eneajaho the linked PR is the basic idea. Let me know if it is a good idea to add that option.

I agree, it shouldn't get triggered if you commenting it out. Not sure why tho.

Thanks! Your library is really awesome. So my current plan is rename regeneration to generation and add another param for different mode, since they actually behave a little different. But...

I think we shouldn't have 2 different configs to modify the html for serveFromCache and render https://github.com/rx-angular/rx-angular/blob/3f919167f68a1bc969e95876d81a4dbace306fc1/libs/isr/models/src/isr-handler-config.ts#L127 https://github.com/rx-angular/rx-angular/blob/3f919167f68a1bc969e95876d81a4dbace306fc1/libs/isr/models/src/isr-handler-config.ts#L110 I understand the need to have a way to serve different variant...