Maxime Armstrong

Results 40 comments of Maxime Armstrong

> **`fare_transfer_rule_forbidden_duration_limit`** > * spec mention in [`fare_transfer_rules.duration_limit_type`](https://gtfs.org/schedule/reference/#fare_transfer_rulestxt): Forbidden if `fare_transfer_rules.duration_limit` is empty. > * pseudo code: If [`fare_transfer_rules.duration_limit` == '' and `fare_transfer_rules.duration_limit_type` != ''], trigger the notice @isabelle-dr I...

Thank you for reporting this bug @LuisDiezLaso! Currently, this is "normal" behavior - we don't run any validation rules involving multiple files if at least one file is unparsable. In...

Oh, you're right. It looks like it's working when PRs are made from this repo (see [here](https://github.com/MobilityData/gtfs-validator/pull/1204#issuecomment-1178040173) and [here](https://github.com/MobilityData/gtfs-validator/pull/1212#issuecomment-1191414051)), but not from forks. Looking more closely to the run logs,...

I agree with you - I thought the same thing looking at the `checkRuleValidity` method. About combining the reports. I don't think they need to be separate, that's how it...

Oh, thanks. I did not catch this part of the rule.

@barbeau the Python validator pass the service gap interval threshold by parameter, so there's no number of days define in the code to my knowledge. @timMillet The spec doesn't seem...

@barbeau my bad, I thought it was passed by parameters, but I figured out the service gap threshold is computed when the method is called https://github.com/google/transitfeed/blob/master/transitfeed/schedule.py#L972

@barbeau Here https://github.com/google/transitfeed/blob/master/transitfeed/trip.py#L644

Hi @gcamp ! Thanks for the details. Unfortunately, we were not able to reproduce the exact same behavior using `cgroup` + `-Xmx`, where the validator deadlocks. In every test run,...

Hi @rpedraza01! After testing the validator with your dataset, I found the problem. Currently, the validator uses the first and last stop times of each trip to compute the overlap...