gtfs-validator icon indicating copy to clipboard operation
gtfs-validator copied to clipboard

Implement trip distance vs. shape verification (GTFS rule)

Open maximearmstrong opened this issue 4 years ago • 3 comments

Is your feature request related to a problem? Please describe. The distance traveled by a trip should be less or equal to the max length of its shape. This is a GTFS rule implemented in Google Python validator and featured in Google Type Error as TYPE_TRIP_WITH_OUT_OF_ORDER_SHAPE_DIST_TRAVELED.

Describe the solution you'd like Actual Google GTFS validator behaviour : verifies if distance travelled is smaller than shape length

Describe alternatives you've considered

Additional context Line 141 in Error support priorities https://docs.google.com/spreadsheets/d/1vqe6wq7ctqk1EhYkgtZ0_TbcQ91vccfs2daSjn20BLE/edit#gid=0

maximearmstrong avatar May 04 '20 18:05 maximearmstrong

@maximearmstrong Could you point us to where this rule is implemented in the Python validator? I don't see it from a quick search.

barbeau avatar Jul 07 '20 14:07 barbeau

@barbeau Here https://github.com/google/transitfeed/blob/master/transitfeed/trip.py#L644

maximearmstrong avatar Jul 21 '20 16:07 maximearmstrong

Labeling as blocked because there is no mention of this in the spec or best practices

isabelle-dr avatar Oct 03 '22 19:10 isabelle-dr

We have a PR open to add this to the spec: https://github.com/google/transit/pull/380. If this doesn't pass, we can discuss adding this as INFO.

isabelle-dr avatar Jun 10 '23 17:06 isabelle-dr

Unblocked now that https://github.com/google/transit/pull/380 has passed 🎉

@cka-y's work on the analytics for the spec issue will be relevant to the logic here.

emmambd avatar Jul 28 '23 13:07 emmambd