gtfs-validator
gtfs-validator copied to clipboard
Implement trip distance vs. shape verification (GTFS rule)
Is your feature request related to a problem? Please describe. The distance traveled by a trip should be less or equal to the max length of its shape. This is a GTFS rule implemented in Google Python validator and featured in Google Type Error as TYPE_TRIP_WITH_OUT_OF_ORDER_SHAPE_DIST_TRAVELED.
Describe the solution you'd like Actual Google GTFS validator behaviour : verifies if distance travelled is smaller than shape length
Describe alternatives you've considered
Additional context Line 141 in Error support priorities https://docs.google.com/spreadsheets/d/1vqe6wq7ctqk1EhYkgtZ0_TbcQ91vccfs2daSjn20BLE/edit#gid=0
@maximearmstrong Could you point us to where this rule is implemented in the Python validator? I don't see it from a quick search.
@barbeau Here https://github.com/google/transitfeed/blob/master/transitfeed/trip.py#L644
Labeling as blocked because there is no mention of this in the spec or best practices
We have a PR open to add this to the spec: https://github.com/google/transit/pull/380. If this doesn't pass, we can discuss adding this as INFO.
Unblocked now that https://github.com/google/transit/pull/380 has passed 🎉
@cka-y's work on the analytics for the spec issue will be relevant to the logic here.