Maximilian Huber

Results 100 comments of Maximilian Huber

## this can't handle optional properties like `createdUsing`? If the parent collection has a creation info with that, and the element does not have it. It is not clear if...

No, I think that support for isOrdered, isUnique and isOptional is not yet supported by spec-parser and this PR contains no documentation that describes their semantics. These come also from...

> This has not been needed for SPDX licensing use cases up to this point, and I disagree that it is a bug or a shortcoming. I think that it...

> People reading this thread: > How important is it for signal-export to continue to exist, given that `sigtop` also exists? Does signal-export have some important features that the other...

Hi @steffen-weber, is this issue already solved by the commit, which closed #453?

On a vagrant installation one can run ``` $ cd /vagrant/src/cli/tests/ $ sudo FOSSOLOGY_TESTCONFIG=/usr/local/etc/fossology /vagrant/src/vendor/bin/phpunit -c/vagrant/src/phpunit.xml test_cp2foss.php ``` When calling this script this way, the tests run but then two...

**1)** TODO **2)** In the second assertation is asserted that the `count()` of the following Array is **10**, this number seems to be outdated. ``` Array ( [0] => The...

> I just checked the implementation of walk. It seems still relying on ls. @ejguan I should have completely read your comment earlier. Just tried to work on that issue...

Can you please also add tests to show and test the new behaviour?

As this is also relevant for matching and relating licenseRefs, I assume that this also needs changes beyond the validation layer.