Maximilian Huber

Results 100 comments of Maximilian Huber

Hey @jwagantall or @fabiopalumbo, can you create a fork of https://github.com/openstack-archive/deb-python-aioeventlet to https://github.com/magma/deb-python-aioeventlet/. Write permissions should be given to @magma/approvers-agw-pipelined. This was discussed and approved in https://wiki.magmacore.org/display/HOME/June+27%2C+2022+Meeting. Once the fork...

Hey @sklgromek , you labeled it [candidate-for-backporting](https://github.com/magma/magma/labels/candidate-for-backporting). Is that actually fixing a bug and is a **must** and blocks release testing? Is it a nice to have? If it is...

please rebase and fix `Bazel Build & Test`

please rebase, `please rebase` is still red

it is red, so your PR is not fully rebased. Can you fix that please? ![2022-08-12_16:39:48](https://user-images.githubusercontent.com/1187050/184378848-bbc88cd2-b6ab-4064-bcee-33a0f150786f.png)

@rmeleromira , this looks to be stale and not much moves. Can we close it?

> I think here it would be good to do an integration test run on your fork before the merge. I have done that before creation of the PR

Just as a snapshot how tools handle that today (for the example https://pkg.go.dev/github.com/russross/blackfriday/v2 in version v2.1.0): - ORT: `pkg:golang/github.com%2Frussross%2Fblackfriday%[email protected]` - Syft: `pkg:golang/github.com/russross/blackfriday/[email protected]` - SCTK: `pkg:golang/github.com/russross/blackfriday/[email protected]` - component-detection: * `"Type": "golang",`...

The example `pkg:generic/[email protected]?download_url=https://openssl.org/source/openssl-1.1.0g.tar.gz&checksum=sha256:de4d501267da` would then be rather unreadable: ``` pkg:generic/[email protected]?download_url=https%3A%2F%2Fopenssl.org%2Fsource%2Fopenssl-1.1.0g.tar.gz%26checksum%3Dsha256%3Ade4d501267da ```