Max Bowsher

Results 104 comments of Max Bowsher
trafficstars

It looks like this is now being worked on, in #18683 ! :-)

@sgmiller Please re-open since the implementing PR was reverted, thanks.

I've edited the originally submitted reproduction recipe, replacing with a simpler one, which also showcases an additional issue.

> Hey folks, after a lot of testing in #1676, it seems that setting `HTTP_PROXY` and `HTTPS_PROXY` works, but `http_proxy` and `https_proxy` doesn't. I think it is prudent to introduce...

I happened to be reading the README and found some more broken links - and found this PR when I came to report them. The links to the GitHub issues...

> it's a good idea to set the application home directory to be also /opt/vault, instead of the default /home/vault. Could you elaborate on why you think it's a good...

I'm just another Vault contributor, so don't take what I say as a requirement - but here are some things I think it would be nice to consider: * Vault...

> * Rather than writing a chunk of new separate code for this, what about just having `VAULT_TOKEN_FILE` override where the existing code, in `command/token/helper_internal.go` looks for the token? Now...

I keep seeing this PR pop up in my GitHub notifications due to repeated force-pushing. I'm not sure there's any point in doing that, @nwoythal.

Ah, only 2 months... one of mine is still open after 7 months without more than an initial holding response. Unless you catch the attention of an engineer who happens...