Max Bowsher
Max Bowsher
I came here via investigating why a dependent project (HashiCorp Consul) was emitting extra spurious metrics with differing label sets. I discovered it's actually a suboptimal work-around for go-metrics' API...
The name of the metric as registered with the metrics library to provide the help string, was incorrect compared with the actual code that sets the metric value - bring...
`hclwrite.NewFile` and `hclwrite.NewEmptyFile` are, on closer inspection, functionally identical duplicate code. Suggestion: Replace `NewFile` (which manually reimplements `newBody` instead of invoking it) with a trivial deprecated wrapper invoking `NewEmptyFile`. (Or,...
This release: https://github.com/hashicorp/hcl/commits/v1.0.1-vault-3 contains two commits which are not included in the branch for this fork: https://github.com/hashicorp/hcl/commits/1.0.x-vault and so there is a risk of them being lost in a future...
Whilst reading the code, I noticed a problem with the configuration merging logic. Consider the case of setting something to a non-default value in the main server configuration and then...
This PR relates to a feature request logged through HashiCorp commercial support: https://app.asana.com/0/112957393038545/1201850823939444/f Vault lacks pagination in its APIs. As a result, certain list operations can return **very** large responses....
Scenario: A 3-node Vault cluster using Raft storage, accessed via a load-balanced URL which can contact any one of the unsealed nodes. Attempt to use `vault operator raft snapshot save`:...
This part of the CLI help message is incorrect: https://github.com/hashicorp/vault/blob/967b2987e5a17a82f9b46b6d0b4f93b42fd550cd/command/operator_generate_root.go#L80-L82 The `-otp` flag is not needed or used, when providing an unseal key shard. It is only for use in...
e.g. #18510