Maximilian Roos

Results 250 issues of Maximilian Roos

I've been using this approach to test `cargo-insta` locally; would it make a reasonable test for CI too?

I got confused at https://github.com/mitsuhiko/insta/pull/489/files#r1640317409

I did some more testing. There are some corner-cases where it doesn't work; for example if `info` is used it fails, because our serializer / deserializer doesn't roundtrip. For example;...

Running `require-full-match` without `cargo-insta` (or with `cargo insta --check`) wasn't working on inline snapshots, since those snapshots don't have metadata. I'm also going to PR to make `require-full-match` experimental, since...

In an effort to simplify the configs, this merges the `INSTA_UPDATE` and `INSTA_FORCE_UPDATE` configs. Conceptually, `INSTA_FORCE_UPDATE` overwrites `INSTA_UPDATE`; they naturally fit into the same config setting. I realized after starting...

### What happened? with a test like: ```rust #[test] fn test_inline() { insta::assert_snapshot!(3 + 2, @""); } ``` ... running `INSTA_UPDATE=always cargo test` gives: ``` error: cannot update inline snapshots...

bug

This is the code for https://github.com/mitsuhiko/insta/issues/456#issuecomment-1979089438, as mentioned in https://github.com/mitsuhiko/insta/pull/466. There's a very small breaking change in YAML inline snapshots — shown here in the tests. In return, it cuts...

We're attempting to upload lots of files. We're passing in a glob here: https://github.com/PRQL/prql/pull/4568/files#diff-e426ed45842837026e10e66af23d9c7077e89eacbe6958ce7cb991130ad05adaR319-R329 That glob correctly picks up the files when in a normal `run:`, from https://github.com/PRQL/prql/actions/runs/9439404299/job/25997680563?pr=4568: ``` Run...