Maximilian Roos

Failures within `glob!` & `allow_duplicates!` should show output

3

If a normal snapshot doesn't match, we get a very nice output: ``` $ cargo insta test -p prql-compiler --check ... failures: ---- semantic::resolver::test::test_functions_pipeline stdout ---- ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Snapshot Summary ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━...

API to read snapshots

6

Edit: to avoid reading this wall of text, see [this comment](https://github.com/mitsuhiko/insta/issues/353#issuecomment-1464986801) for a summary Below is the original comment --- We have a process in PRQL to extract, compile, and...

### What happened? Very minor: Running `cargo insta test` with `--check` or `CI=1` and failing prints this error message, which seems designed for folks running `cargo test` ``` Stopped on...

### What happened? We have a layout like: ``` prql-compiler |- Cargo.toml |- src |- ... |- prqlc |- Cargo.toml |- src |- ... ``` When there's a single pending...

I'm often getting an error: `error: No such file or directory (os error 2)` which exits the process. I get this when reviewing snapshots, and occasionally when just running `cargo...

Would stripping ansi escape codes be a reasonable addition to the Settings? We could pass the string through something like https://docs.rs/anstream/latest/anstream/adapter/fn.strip_str.html.

Shorten snapshot file names?

1

This might be too much of a breaking change, or I might be misunderstanding the structure, but: we current have snapshots at a path like: ``` web/book/tests/examples/snapshots/examples__book__introduction__0.snap ``` This is...

Compatibility with workspace inheritance

15

Related to https://github.com/foresterre/cargo-msrv/issues/295, but I think not the same. Currently running `cargo msrv verify` on https://github.com/prql/prql within `prql-compiler` raises an error: ``` ❯ cargo msrv verify Fetching index Unable to...

Representing infix `REGEXP`

8

[MySQL](https://dev.mysql.com/doc/refman/8.0/en/regexp.html) & Sqlite have unusual regex operators: ```sql SELECT 'a' REGEXP '^[a-d]'; ``` i.e. it's an infix function. We are big users (and big fans!) of `sqlparser-rs` in PRQL We...

`var_names` not needed when DataArrays are passed

2

\@dcherian pointed me towards this library in https://github.com/pydata/xarray/discussions/7498, it looks awesome! Very small point — when I have something like the linked example, but add a cast to a DataArray...