insta icon indicating copy to clipboard operation
insta copied to clipboard

Pending snapshot in nested crate is double-counted

Open max-sixty opened this issue 1 year ago • 0 comments

What happened?

We have a layout like:

prql-compiler
|- Cargo.toml
|- src
|- ...
|- prqlc
   |- Cargo.toml
   |- src
   |- ...

When there's a single pending snapshot inside prqlc:

  • insta reports "2 pending snapshots"
  • On cargo insta review, if the first is accepted or rejected, we get an "File not found" error when it attempts to find the file for the second time (#380)
  • If we skip, the only change between the two within cargo insta review is that the crate changes from prqlc to prql-compiler

Insta Version

1.30

rustc Version

1.68

max-sixty avatar Jun 27 '23 06:06 max-sixty