mauropasse

Results 24 comments of mauropasse

I've been testing the new feature enabled by: ``` bool inter_process_publish_needed = get_non_local_subscription_count() > 0; ``` This not only fixes the "double delivery" issue (local subscription receiving intra & inter...

Correction about my statement above: > This not only fixes the "double delivery" issue.. This PR _doesn't_ fix the double delivery issue. It _does_ avoid getting inter-process messages at creation/destruction...

The issue can be fixed by re-ordering [ClientBase::execute](https://github.com/ros2/rclcpp/blob/5e14a283b67940526a20c365b827d8090a552bad/rclcpp_action/src/client.cpp#L622) and [ClientBase::take_data()](https://github.com/ros2/rclcpp/blob/5e14a283b67940526a20c365b827d8090a552bad/rclcpp_action/src/client.cpp#L551C1-L551C24) such as: ``` if (pimpl_->is_feedback_ready) { ... } else if (pimpl_->is_status_ready) {...} ``` go as the last conditions. So it'd...

> Is the design of Waitable intended to have implementations execute all of their work on execute(...) or only some of it? The idea is that one single `execute()` of...

https://github.com/eProsima/Fast-DDS/pull/3841 This PR should add support for this feature

> Could you explain that in more detail? There are two situations in which a wait-set based executor can be awaken when something changes related to the timer, by means...

> Could the clock jump callbacks be used for that though? Yes, no need to add an extra callback for it. I removed the callback call on `_rcl_timer_time_jump`. That function...

Hi @clalancette, I'll complete it today/tomorrow and it should be ready. Thanks

@clalancette I completed some missing sections and added some experiments I run using the proposed implementation. So I think this is ready to be reviewed.

@timonegk this PR https://github.com/ros2/rmw_fastrtps/pull/625 fixes the issue you got about an invalid qos type falsely triggered. So you don't have to revert the FastRTPS PR https://github.com/ros2/rmw_fastrtps/pull/583