Fast-DDS icon indicating copy to clipboard operation
Fast-DDS copied to clipboard

Add support for XML environmental variables parsing [10697]

Open mauropasse opened this issue 4 years ago • 5 comments

This commit would allow to use OS environmental variables in XML profiles. For example:

# In bash terminal
export ROBOT_IP_ADDRESS=192.168.0.1

# In XML profile
<?xml version="1.0" encoding="UTF-8" ?>
<profiles xmlns="http://www.eprosima.com/XMLSchemas/fastRTPS_Profiles">
    <participant profile_name="env_var_parsing_example">
        <rtps>
            <builtin>
                <initialPeersList>
                    <locator>
                        <udpv4>
                            <address>ROBOT_IP_ADDRESS</address>
                        </udpv4>
                    </locator>
                </initialPeersList>
            </builtin>
        </rtps>
    </participant>
</profiles>

mauropasse avatar Oct 23 '20 13:10 mauropasse

Build status:

  • Linux Build Status
  • Linux aarch64Build Status
  • Mac Build Status
  • Windows Build Status

richiware avatar Oct 24 '20 12:10 richiware

Hi, sorry for resurrecting this old PR. Is there anything that is preventing it to be merged?

irobot-ros avatar Feb 25 '21 16:02 irobot-ros

@irobot-ros Just that we did not have time to review it. Will do it now.

MiguelCompany avatar Feb 26 '21 08:02 MiguelCompany

Hi @irobot-ros,

The base branch for this PR (2.0.x) is becoming EOL (end of life) this very month (see release support document). This is not going to be merged into this branch because there is still work pending. If you want to keep this PR open, you can change the base branch to one of the branches still alive and rebase it: 2.1.x used in ROS 2 Foxy, 2.3.x used in ROS 2 Galactic, or directly to master.

Sorry for the inconvenience!

JLBuenoLopez avatar Feb 22 '22 10:02 JLBuenoLopez

Sure, sorry for keeping this PR open for so long but we didn't have time to fully implement it as requested. Will close this PR.

alsora avatar Feb 22 '22 10:02 alsora

I am closing this PR, though the feature is something which will be interesting to have in Fast DDS. I have opened #3377 to keep track of this feature. Also, this PR is targeting a branch that is no longer alive. A PR targeting master with this feature can be opened in the future.

JLBuenoLopez avatar Mar 16 '23 13:03 JLBuenoLopez

https://github.com/eProsima/Fast-DDS/pull/3841 This PR should add support for this feature

mauropasse avatar Sep 15 '23 11:09 mauropasse