matzemathics

Results 12 comments of matzemathics

@dswij I got (still am) somewhat confused, because the suggested `lib::expr_use_ctxt` did not manage to find the parents: It returns an `ExprUseCtxt { ExprUseNode::Other, ... }` if the expression is...

> Does this PR resolve the same issue? Yes, however it currently only deals with some special cases and a more general solution seems very much possible. > This lint...

On that note, I am not sure it is ideal to have our "public api" depend on types of external crates, if we _do_ consider our code "library code".

Maybe it suffices to make the `ReadingError` dynamically typed?

> We're building a library, though, not an application, so thiserror is the appropriate choice I am also not sure what potential users would want to deal with the huge...

@mmarx, I don't think this must necessarily be solved by the parser, because such "global" properties usually will make the parser much more complicated. I think this might should be...

> Yeah, probably needs a better tag. Any suggestions? something like "Analysis" / "Program Analysis" ?

I did some further investigation, and it seems addressing this needs some larger architectural changes. Currently there is just no way to handle tables with 0 columns through the `PartialTrieScan`...

A minimal example of that bug would be ```prolog T(1). R(?y + 1) :- T(?x), ?y = ?x + 1. @output R . ```