Matthijs Kooijman
Matthijs Kooijman
> The idea is that you never need to change these Git hooks, because the actual hook logic you need to change is inside your tracked repository. This is true,...
> Since you're making your own local changes anyway, perhaps it would make sense to have your own setup too? Yeah, what you describe is pretty much what I did...
I just left a review on #92. While reviewing, I noticed some other things, which probably related more to #86, or are otherwise possible improvements of the current code, not...
> Or the git core.hooksPath mode? That one.
Yeah, exactly. But the current code does not seem to work like that yet, it still uses the template directory code to generate a core.hooksPath directory AFAICS. This is likely...
> Hm, I can't remember the exact details now, but I thought it either uses the existing core.hooksPath directory or creates one if it does not exist, copies the hook...
> I intend to doo that, once we get onwith deprecating single instal... Ok! > I do not quite agree here, the user can already have set core.templateDir ahead of...
> One thing about hooks leaving in place an such is also the thing about the git LFS hooks, they get installed by git directly. Ok, good example. But how...
I personally would not want to use the `templateDir` approach (I like the centrally managed `hooksPath` better), but I can see the value of it, so I would also think...
> @matthijskooijman : LFS hooks are completey supported by githooks it self. They get move and disabled if detected in the .git/hooks folder. disable_lfs_hook_if_detected() Ah, I see that now. It...