Matthijs Kooijman

Results 990 comments of Matthijs Kooijman

Thanks for your PR, apologies for not responding to it earlier... I've looked at the patch and it seems useful, but I wonder if it would maybe be better/simpler to...

> but I cannot find any function named timestamp() in fields.h. I can directly access gas_delivered.timestamp (the variable, not the function), but that is not how it is documented It...

IIRC checksum errors can also prevent the reader from returning `available()` as `true` (but I also think that error logging here isn't ideal currently). If there is no request pin,...

I had to dig into the code again, it has been a while and maybe I made this thing too complex :-p Anyway, I think the problem is that the...

W00ps, I accidentally used `apply(float)`, but that should be `apply(FixedValue)` instead. I've updated my previous comment.

I think my previous suggestion was not actually working because there is no single `FixedField` class, but it is a template that is instantiated once for every particular field (which...

Interesting! Would be nice to also support the Belgian standard, looking forward to see what you come up with :-)

I haven't looked in detail (bit busy atm), but if it is just the OBIS numbers and the associated formats that are different while the telegram format itself is the...

Let's keep this issue open until it is actually solved. I read a bit through the Belgian specification, still playing around with it a bit to figure out the best...

I've looked closely at the belgian spec, and wrote a bit to put into the README later (added at the bottom of this command). As for implementing this, I'm just...