Matthijs Kooijman

Results 993 comments of Matthijs Kooijman

Agreed that the code does not match the text, and I think the code is not entirely correct either. Ideally, you sample halfway each bit time, which the code does...

> What's wrong with the OGFX-source on cdn.openttd.org ? Nothing, I guess, when it's properly documented. Looking at the README again, it does seem it references cdn.openttd.org, so that's actually...

> This is the same for all our other projects btw; I guess mostly it requires someone figuring out how to publish files nicely to GH via our workflow :)...

> @pawamoy thanks for the reference, i wonder if a managed global to inform the hook of the correct expected toplevel would sort this out nicely Isn't this what `root`...

> Would you be able to open a PR for this by any chance? Sorry, too much on my plate already. Sorry for spilling all my wishes and suggestions without...

It's not something critical in any case. And maybe I'll get annoyed by the repeated prompt enough to prepare a PR anyway after a while :-p

> what should we do if ACCEPT_CHANGES is empty (e.g we have no controlling terminal meaning) My suggestion would be to look at the exit status of `show_prompt` to detect...

One can also argue that in `core.hooksPath` mode, githooks has not installed anything into actual repositories (has not even touched them at all), so there is little need for "migrations"...

I just tried this and it actually seems to work quite well so far. I: - Created a git clone in ~/.local/etc/ - Created a `~/.githook/hooks` subdirectory - Inside that...

> Before we do that though, I want to clarify what is the actual problem we're trying to solve? You can already clone this repo and run ./install.sh - what's...