Matthias Kern

Results 6 comments of Matthias Kern

I could help with testing on another react app which has cra-like setup. Would also be interested in directly contributing if there are any low-hanging fruits.

how about adding an ignore flag instead of noop? ``` fpack --preprocess-ignore='node_modules/*.js' -- preprocess='*.js' ```

@zindel seems like a good compromise. `ignore` is very explicit

This would require changes to https://github.com/Sketch-sh/sketch-sh/blob/f7d74a78ebe122ef0b623aa6db1bcc61b80153de/client/src_editor/reason-mode.js#L77 Related: https://github.com/Sketch-sh/sketch-sh/issues/195

Thinking about these: ![image](https://user-images.githubusercontent.com/9108002/44509275-f0911280-a6b9-11e8-8fe2-4e52aa069a52.png) Could be adjusted to look more like the screen it is loading,e.g.: ![image](https://user-images.githubusercontent.com/9108002/44509306-0dc5e100-a6ba-11e8-95b6-67ae8c4bdf89.png)

I'd be interested in helping to get this fixed as we're running into this in production with [llama_index](https://github.com/run-llama/llama_index/issues/7241).