sketch-sh icon indicating copy to clipboard operation
sketch-sh copied to clipboard

Published 20 hours ago • verified publisher icon Sketch-sh

Error in syntax highlighting for Ocaml

Open jeroenpelgrims opened this issue 6 years ago • 2 comments

Example: https://sketch.sh/s/h7mXF4K6jtQXY1cflQJHhT/

As you can see in the example, when using the double quote character in a character literal the syntax highlighting starts to freak out. It seems to think I've opened a string but not closed it.

jeroenpelgrims avatar Oct 31 '18 00:10 jeroenpelgrims

This would require changes to https://github.com/Sketch-sh/sketch-sh/blob/f7d74a78ebe122ef0b623aa6db1bcc61b80153de/client/src_editor/reason-mode.js#L77

Related: https://github.com/Sketch-sh/sketch-sh/issues/195

matthiaskern avatar Nov 06 '18 14:11 matthiaskern

@matthiaskern This is related to OCaml syntax highlighting so I belive this could be brought up to codemirror's maintainer attention or we can fork the ocaml syntax highlighter into Sketch's repo

thangngoc89 avatar Nov 06 '18 15:11 thangngoc89