Matthias Bläsing

Results 186 comments of Matthias Bläsing
trafficstars

> I left a few inline comments, but I made a general observation, that the integration looks a bit strange right now: > > ![image](https://user-images.githubusercontent.com/2179736/183994346-6de71823-7850-4201-b852-32c0995c9fc7.png) > > As you can...

@Chris2011 NB18 is coming nearer. Shall this stay on the NB18 milestone, then an update would be good now (branch happens in 8 days) or moving to NB 19 should...

Removed the NB18 milestone and converted this to draft.

My gut feeling is, that the HtmlHintsProvider and the expectations of the CslTestBase/GsfHintsManager don't match. It seems suggestions were never really supported. It might be worthy looking into JS/CSS whether...

@qmegas please check PR #5995, which should fix this issue. A test build is available from the PR summary page: https://github.com/apache/netbeans/actions/runs/5100679715 or directly via: https://github.com/apache/netbeans/suites/13194152319/artifacts/718900999

@FurmigaHumana at least there are no other discussion on going about this. I think the hard part is to define what you want to accomplish and how that might fit...

We have now #6480, the approach @lahodaj took to fix the hyphen vs. underscore problems looks easier to me and does not involve changing the netbeans module system.

I intent to merge this by next week, so if anyone wants to object, please do so now.

This was tested and is reviewed. I rebased on master, gave it another mini-spin and if tests run clean, I plan to merge tomorrow.

The module depends on JAXB (Java Architecture for XML Binding). It was bundled with the JRE. With JDK9 several modules were removed from the JDK, including JAXB. I updated the...