netbeans icon indicating copy to clipboard operation
netbeans copied to clipboard

Add support for Chrome DevTools Protocol for NodeJS Debugging

Open matthiasblaesing opened this issue 3 years ago • 5 comments
trafficstars

Highlight the hit breakpoint (see Marker in the "Breakpoints" Tab):

image

In the Global Node Configuration the debug protocol to be used can be selected, it defaults to the "Chrome DevTools protocol":

image

It would have been possible to select the protocol based on the version information from node, however the node from graalvm can't be safely and quickly detected, so the user has to choose.

In the per Project Settings the Node Debug Protocol can be overridden together with the node binary, as the two depend on each other:

image

matthiasblaesing avatar Jun 11 '22 20:06 matthiasblaesing

Just a question, will this also work out of the box for TypeScript?

Chris2011 avatar Jun 12 '22 10:06 Chris2011

Just a question, will this also work out of the box for TypeScript?

I don't think so. The foundations could be used, but it needs to be integrated.

matthiasblaesing avatar Jun 12 '22 11:06 matthiasblaesing

Can we merge this one ?

ebarboni avatar Oct 04 '22 15:10 ebarboni

@matthiasblaesing we're getting close to freeze now, so need a call whether to merge for NB16, punt to NB17, or close.

neilcsmith-net avatar Oct 11 '22 12:10 neilcsmith-net

Moved to 17 - I'd like to have another look at this.

matthiasblaesing avatar Oct 11 '22 18:10 matthiasblaesing

I intent to merge this by next week, so if anyone wants to object, please do so now.

matthiasblaesing avatar Nov 29 '23 19:11 matthiasblaesing

I see no milestone but this PR looks ok. Could we make it for NB 22 ?

ebarboni avatar Apr 05 '24 08:04 ebarboni

This was tested and is reviewed. I rebased on master, gave it another mini-spin and if tests run clean, I plan to merge tomorrow.

matthiasblaesing avatar Apr 14 '24 19:04 matthiasblaesing