Matthias Bläsing

Results 187 comments of Matthias Bläsing

I noticed, that at least in some cases the class, that opens the dialog is itself an instance of `java.awt.Component`. In that case it could be passed to `JFileChooser#show*Dialog` and...

Change looks sane to me, however I suggest to include this in this change set (if in doubt, feel free to squash it into your commit): https://github.com/apache/netbeans/commit/66716b5506d91257f8ea136ffb11a669bac53f3a The intention is...

> @matthiasblaesing that change looks a good idea. Thanks for having a look. > I wonder if we should be pre-extracting the native libs similarly to [how JNA module does...

@neilcsmith-net thank you for the pointer - I looked one level to deep. What do you think about this: https://github.com/apache/netbeans/commit/6781772b899fdfeaf855ed6b20d071b8bcf5fe60 @DevCharly the referenced commit should change the library loading, so...

@neilcsmith-net valid point updated to: https://github.com/apache/netbeans/commit/be4dba61b9f6aa74089798095663fa3b917923d8 @DevCharly if you consider this, please use this commit, not the previous one, I replaced it based on Neils comments.

@DevCharly: You are right - it currently hits the "load from classpath" case @neilcsmith-net You are also right. The issue comes from the fix for https://github.com/java-native-access/jna/issues/384. I think the change...

The jna issue should be fixed by #4736

Yes I agree, that it already looks broken. That does not change my opinion about the change. I suspect somewhere in the HTML Support some intelligence detects external languages and...

Here is a sample that might come from reality (we have several similar examples in our codebase): Before: ![image](https://user-images.githubusercontent.com/2179736/193427535-5421a996-6d3a-4d02-918a-287f0e7d27c3.png) After: ![image](https://user-images.githubusercontent.com/2179736/193427557-f61fe3e2-41aa-424e-92bc-3ec92d1aaea9.png) While I admit, that the original rendering is not...

From my POV the description of CVE-2017-12629: https://nvd.nist.gov/vuln/detail/CVE-2017-12629 is pretty clear, that the attack vector is through the SOLR server, which handles XML in an insecure way. Debian references two...