Matt Mayer

Results 215 comments of Matt Mayer

Nope, if you pass a format parameter to faker.phone.number it directly passes it to the replaceSymbolWithNumber method at the moment

For the original issue, i think the new API should be kept fairly minimal to start with, given the number of possible different "axes" which would make this hard to...

hmm, now i think about it, i think while saying that method "is mostly a black box that does some arbritary char -> digit transformations" is true, those are generally...

sure, but i would say there is no hurry to deprecate replaceSymbolWithNumber at least until we have more flexible options for phone.number() - that way anyone who is currently using...

Anyway this discussion is a bit offtopic, lets discuss deprecation further on https://github.com/faker-js/faker/issues/1994 this issue can be for the future options for the phone.number method.

> > the direct replacement for `faker.phone.number('##########')` is `faker.helpers.replaceSymbolWithNumber('##########')` - maybe the deprecation message should be modified to make that clearer? > > Sorry, but the two methods are not...

> For the original issue, i think the new API should be kept fairly minimal to start with, given the number of possible different "axes" which would make this hard...

> So maybe there's only a single parameter like "style" = `human | raw | national` initially which maps to the combination of these which we think are most likely...

> Only the team can merge, so nothing external contributors can do. We have rules when to merge PRs (wait times for more reviews), but these are irrelevant for others...

@linediconsine this would be useful for the @faker-js/faker project. Would you be interested in rebasing this PR to get it merged, or if you don't have time I could make...