Matt Mayer

Results 288 comments of Matt Mayer
trafficstars

Probably this needs - a few small PRs to fix the patterns - then some upstream changes to validator - then update the tests to verify the all pass the...

There's an open PR for adding maestro support here https://github.com/validatorjs/validator.js/pull/2223

No big hurry 😀 when a project already has 150 open PRs I probably won't help by adding yet another one. For the time being I pinged the original author...

Created a new PR at validator for improved Maestro support. https://github.com/validatorjs/validator.js/pull/2286

Changed my mind... as Maestro is being discontinued https://www.mastercard.com/news/europe/en/perspectives/en/2021/blog-from-valerie-nowak-why-this-maestro-is-retiring-after-30-years/ > Built primarily for a physical world, Maestro cards cannot consistently be used for e-commerce payments, in part because the numbering...

https://en.wikipedia.org/wiki/Japanese_addressing_system

Note that the step feature in #1596 was for float, not for int. If we do it for one we should probably do it for all number methods.

Im still a bit dubious about how useful this parameter is in reality versus just multiplying by a constant as in the workaround posted by @SD-DDT . To get a...

I previously argued for a name something like 'multipleOf' to make it clear it doesn't work in the same way as say the HTML input element https://github.com/faker-js/faker/pull/1855#issuecomment-1444707308

Could you address the comments in the open PR: https://github.com/faker-js/faker/pull/2188#discussion_r1210399970