validator.js icon indicating copy to clipboard operation
validator.js copied to clipboard

Adding Maestro credit card ranges

Open linediconsine opened this issue 2 years ago • 5 comments
trafficstars

Add Maestro brand credit cards ranges regexp

I used the ranges provided credit-card-type here

This should solve a problem that I am facing with some Mastro cards on a work project

Checklist

  • [X] PR contains only changes related; no stray files, etc.
  • [X] README updated (where applicable)
  • [X] Tests written (where applicable)
  • [X] References provided in PR (where applicable)

linediconsine avatar May 10 '23 15:05 linediconsine

@linediconsine this would be useful for the @faker-js/faker project. Would you be interested in rebasing this PR to get it merged, or if you don't have time I could make a new PR?

matthewmayer avatar Sep 09 '23 13:09 matthewmayer

@rubiin Updated Readme and solved conflicts Let me know if I need any other fix here

Thanks (and sorry for the delay)

linediconsine avatar Jan 26 '24 17:01 linediconsine

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b958bd7) 99.95% compared to head (1cfa3ad) 99.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2223      +/-   ##
==========================================
- Coverage   99.95%   99.95%   -0.01%     
==========================================
  Files         107      107              
  Lines        2454     2449       -5     
  Branches      619      619              
==========================================
- Hits         2453     2448       -5     
  Partials        1        1              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 26 '24 18:01 codecov[bot]

@profnandaa @tux-tn @pano9000 could you please review my PR ? Thanks

linediconsine avatar Jan 31 '24 15:01 linediconsine