faker
faker copied to clipboard
faker-js
Verify all credit card issuer patterns are valid with validator.js
We're currently not sure if all of our credit card issuer patterns are valid patterns. We should check them with validator.js.
Do you mean to check them in tests here, or in runtime as new dependency in faker?
This issue only requires the implementation of the tests or fixing possible invalid patterns as well? If only the first one, this might be a good first issue.
It might also be fixing patterns. Or making sure the validatorjs' validation patterns for the credit cards are valid.
I ran a large number of generated numbers through validator.isCreditCard. First the general check (no provider)
{
mastercard: { valid: 91151, invalid: 0 },
jcb: { valid: 90173, invalid: 0 },
american_express: { valid: 90996, invalid: 0 },
diners_club: { valid: 91178, invalid: 0 },
discover: { valid: 30566, invalid: 61030 },
visa: { valid: 90643, invalid: 0 },
maestro: { valid: 16220, invalid: 74712 },
}
discover and maestro cards have problems, rest are OK.
Additionally when running validator.isCreditCard(ccnumber, {provider: ...}) some diners_club and mastercard cards fail. maestro is not a supported provider by validator.
There are six patterns for discover in Faker.
These two succeed:
65##-####-####-###L
6011-####-####-###L
These four fail:
A) 6011-62##-####-####-###L
B) 64[4-9]#-62##-####-####-###L
C) 65##-62##-####-####-###L
D) 64[4-9]#-####-####-###L
For reference the validatorjs regex is /^6(?:011|5[0-9][0-9])[0-9]{12,15}$/
Referring to https://web.archive.org/web/20170822221741/https://www.discovernetwork.com/downloads/IPP_VAR_Compliance.pdf
it would seem to be that patterns A, B, C are incorrect on Faker's end. They generate 20 digit CC numbers which are invalid as the max length is 19. Pattern D is incorrect on validator's end, as Discover cards may start with 64 and be 16 digits.
In order to properly support maestro, this would need to be added to validator.
According to Wikipedia Maestro cards are 12-19 digits long and start with one of these prefixes:
6759, 676770, 676774, 5018, 5020, 5038, 5893, 6304, 6759, 6761, 6762, 6763
mastercard has two patterns in Faker. Both pass the general isCreditCard check but
`5[1-5]##-####-####-###L' succeeds but '6771-89##-####-###L' fails.
The validator regex is /^5[1-5][0-9]{2}|(222[1-9]|22[3-9][0-9]|2[3-6][0-9]{2}|27[01][0-9]|2720)[0-9]{12}$/
This seems to be a weird edge case for card numbers starting 677189 which is actually detected as a unionpay card by validator!
Would suggest to remove this pattern (which appears in a full 50% of generated mastercard numbers and replace with a more common prefix, like the new "2" prefixed cards https://www.cardfellow.com/blog/new-mastercard-bins/
Probably this needs
- a few small PRs to fix the patterns
- then some upstream changes to validator
- then update the tests to verify the all pass the validator checks
There's an open PR for adding maestro support here
https://github.com/validatorjs/validator.js/pull/2223
@matthewmayer just as a headsup; merging PRs in validator happens infrequently and at random moments. So it would be best not to rely on outdated PRs but try to make all upstream changes to validator in a single PR
No big hurry 😀 when a project already has 150 open PRs I probably won't help by adding yet another one. For the time being I pinged the original author of the maestro PR to see if they want to take it on.
Frankly I'm not convinced the credit card method is very frequently used given
- it has output defunct patterns for years and no one has complained
- very few applications should ever be directly handling credit card numbers or storing them in a database. Typically it's always handled by a third party payment processor.
So while this is a nice to fix I don't think it's impacting many users of Faker.
Created a new PR at validator for improved Maestro support. https://github.com/validatorjs/validator.js/pull/2286
Changed my mind... as Maestro is being discontinued https://www.mastercard.com/news/europe/en/perspectives/en/2021/blog-from-valerie-nowak-why-this-maestro-is-retiring-after-30-years/
Built primarily for a physical world, Maestro cards cannot consistently be used for e-commerce payments, in part because the numbering convention on Maestro cards (up to 19 digits) is not compatible with widely used e-commerce portals.
The existing patterns in Faker don't match what Mastercard publish as the BIN ranges at https://developer.mastercard.com/bin-lookup/documentation/support/
And validator doesn't currently support it.
I think it would be best to just remove Maestro completely similar to #2356
I was thinking of ´taking on this issue, but immediatly got stuck as I was not sure where these tests would be located at.
- As a new describe block in
test/modules/finance.spec.ts - As a new case in
test/all-functional.spec.ts - As a new block in
test/locale-data.spec.ts - Somewhere else?
I'm kinda lost and would appreciated some feedback.