Matt Mayer

i created #3467 as a proof of concept for this idea. The exact names to include in the common list and percentages could be debated, but it definitely makes things...

Which locale are you using? https://fakerjs.dev/guide/localization.html#available-locales Note that not every locale has localised phone numbers yet but we welcome contributions to add additional locale data.

> 2. I view SWIFT/BIC numbers as just a different _kind_ of routing number, and therefore found the function name being simply `routingNumber()` and not something like `abaRoutingNumber()` a little...

There's a few ways you could do it. For 1 to 10 you could check if it's any of the values from I to X by listing all 10 values....

Ideally please run preflight after every change. This will help catch any minor syntax errors etc so the reviewers can focus on the logic of your code rather than nitpicking.

> Expected exactly one element for jsdocs its not a very intuitive error message but i think the problem is that you're missing a `@since` JSDoc tag add `@since 9.1.0`...

This would be used when just adding or removing locale data in a pull request e.g. https://github.com/faker-js/faker/pull/3173 https://github.com/faker-js/faker/pull/3154 https://github.com/faker-js/faker/pull/3142 Would this simply be a matter of adding `locale` in https://github.com/faker-js/faker/blob/next/.github/workflows/semantic-pull-request.yml...

Hmm, i'm not really a big fan of this idea. I like the fact that the data sources for most methods are simple arrays. Also, I think looking at how...

I'm not too bothered whether we add a new label or not, maybe it's just a question of updating the documentation to make it clearer which one to pick?

Refactors which add new data to existing locales seem different to refactors which actually change code (but don't change the output). But maybe it's fine to call them both refactor.