Matthew Fosdick

Results 105 comments of Matthew Fosdick

Of my more standard random c++ projects to test (boost, chromium, firefox-68, gcc, libreoffice, llvm): - 208651 files were considered - 65529 files had a valid include guard - of...

@jeff-hykin Apologies for not being involved for the last 6 months. The reason this breaks is that `:single_line_macro` matches as the line does not end in `\` It should be...

Maybe I'm missing something, but what breaks if `__deep_clone__` correctly clones includes?

Ok, so the issue is that when using placeholders, reTag doesn't have a chance to retag the placeholders as they are not resolved? This problem should be independent of includes:...

> keeping track of patterns that include themselves The only way this gets resolved is with the recursive nature that the registry allows. If a pattern includes itself there are...

So to formalize the proposal. A Pattern is Deferred if a pattern is not capable of executing `#to_tag`, or `#to_r`. `BasePattern` has three methods added to it. - `BasePattern#deferred?` this...

We may want to reevaluate generating `*.tmLanguage.yaml` files. With, afaik, no text editor or tool supporting yaml language, and with the JSON files being pretty-printed, I not sure what their...

Fairly minor concern but > create a Pattern class instead of having newPattern use regex would prevent `/foo/.maybe(bar)` from working, correct? If so, there are 33 instances of that that...

It seems the majority of the uses for starting with a regexp is looking for a literal (17), with anchors being the nxt largest (6).

The warning for newlines is probably too overly broad to be useful. In particular, the new include pattern trips up my initial warning. Output: ``` There is a pattern that...