Matthew Fosdick
Matthew Fosdick
Ok, so you are talking about the difference between total time and the sum of the total time for each type of match? With fix/cpp/#462, regex testing accounts for ~190ms...
So `value.then(/foo/)` would follow the linked list of next_pattern until nil was found, then place /foo/ there, correct?
What are your thoughts of `or` optionally taking an array of patterns? The english-ness is reduced some but it fixes the issue of `a.or(b).or(c).then(d)` actually becoming `a|b|cd`. Alternatively, this could...
To reiterate, the pattern class would have the following members: - `type` - the type of the pattern (then|or|backref|subcall) - This is most likely going to be used by the...
my concern with the regex attribute is that patterns can be constructed from other patterns ``` a = Pattern.new( match: zeroOrMoreOf(/\*/).then(match: /&/, at_most: 2.times), ) ``` what would `a.regex` be?...
I took the class skeleton you provided and made a very basic proof of concept. Captures are not yet implemented and only the plain form of `.then()` is supported. You...
In the next hour I should have a rewritten capture method to hopefully allow for sub expressions to work. In particular the recursiveness of the design makes determining final group...
Backreference support has been added.
Removed the `!= nil` on a bunch of checks per https://rubystyle.guide/#no-non-nil-checks, seperated the concept of group info and capture hash. I haven't figured out why but the following snippet makes...
So `if @arguments[:tag_as]` would become `if @arguments[:tag_as].is_a? String` ?