Matt Mackay comments

Results 52 comments of


                                            Matt Mackay

feat: add option to exit early if analysis cache is discarded

Sorry, this is stalled on me. I'm juggling quite a bit currently, but I'll see if I can work on this later this week. @gregestren Those comments above make sense...

feat: add option to exit early if analysis cache is discarded

> Hey @mattem - I saw you had some new commits recently. Were you ready for the next (last?) round? Yes please! I thought I saw more comments from @michaeledgar,...

feat: add option to exit early if analysis cache is discarded

Will endeavour to push this over the line by the end of the week!

feat: add option to exit early if analysis cache is discarded

Didn't quite manage the end of the week, but I believe this has everything addressed, with the flag named `allow_analysis_cache_discard`, and CI green. @gregestren 🙏

feat: add option to exit early if analysis cache is discarded

I believe the only real difference is the flag name change, and changed the variable names to follow suite. Only other work I did in the last commit was to...

concatjs_devserver incorrectly depends on rules_webtesting

Oh! That's a bug in packaging, nice find

concatjs_devserver incorrectly depends on rules_webtesting

Filed #2510 for packaging

Switch bazel workspace from build_bazel_rules_nodejs to rules_nodejs

Maybe `bind` can help migrate?

fix: add toolchain setup to bzlmod release snippet

> Also the error in #331 is about rules_rust being absent, so I don't think this is the fix for it. Maybe we should repro first and figure out if...

[Bug]: cannot use `py_venv`

Do you have the toolchain setup? https://github.com/aspect-build/rules_py/blob/main/e2e/use_release/MODULE.bazel#L8-L10 It's missing from the setup on the releases page, will add.