concatjs_devserver incorrectly depends on rules_webtesting

[mattem]

As seen by @farcaller, concatjs_devserver should not have a dependency on rules_webtesting.

[bduffany]

I ran into this too, worked around it by importing like this:

load("@npm//@bazel/concatjs/devserver:concatjs_devserver.bzl", concatjs_devserver = "concatjs_devserver_macro")

[bduffany]

Also, concatjs_devserver depends on @bazel_skylib: https://app.buildbuddy.io/invocation/7756c70e-91f1-492c-8ab1-3a794ffabd1c#log

[mattem]

Oh! That's a bug in packaging, nice find

[mattem]

Filed #2510 for packaging

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had any activity for 90 days. It will be closed if no further activity occurs in two weeks. Collaborators can add a "cleanup" or "need: discussion" label to keep it open indefinitely. Thanks for your contributions to rules_nodejs!

[ahahn95]

I'm still seeing this issue

[alexeagle]

The concatjs package is in "maintenance mode" so I don't think anyone is going to fix this.

[Mivr]

@alexeagle If concatjs is in maintenance mode what would you recommend as a bundler that follows the ibazel protocol?

[farcaller]

I made a patch to npm's liveserver that allows to use it with ibazel. I bundled it all with rollup.

[Mivr]

@farcaller Thank you for the preposition, I also found this: https://github.com/bazelbuild/rules_nodejs/pull/2431/files (Webpack 5 serve using ibazel, I have not tested it though)

I am actually looking for a solution that is maintained, as the mentioned ones are nice but I do not expect to be able to file a bug and the bug to be fixed. Of course, a self-maintained solution is also an option, but it looks weird to have to write your own dev server rule in order to have any dev server at all, this is a problem mostly for POC or very small projects. I know bazel is not for small projects, but POC for large codebases are small and need quick solutions.

[farcaller]

I guess a good thing about liveserver is that it's pretty limited in what it does, so there's little to fix (in fact it's abandonware but still overwhelmingly popular). But yeah, I wasn't much excited about maintaining an ibazel patch.

[alexeagle]

aspect-build/rules_webpack has an ibazel-aware devserver.

Otherwise yeah it's a missing feature in general, I think big companies are rolling their own.

[Mivr]

@alexeagle Thank you very much these rules look great! I will definitely use these rules in a POC for the organization I work for.

[gregmagolan]

No longer in scope for rules_nodejs which only supplies the Node.js toolchain as of v6.0.0.

Downstream canonical JavaScript + Node.js ruleset is now https://github.com/aspect-build/rules_js.