Matt Caswell

Results 647 comments of Matt Caswell

> ECDSA+SHA256 is interpreted as ecdsa_secp256r1_sha256 These *are* the same sigalg, i.e. they have the same codepoint. This is really a problem with the TLSv1.3 spec which reused the TLSv1.2...

This looks straight forward to add if anyone has the inclination. We have an internal function for this already - so it looks to me like a simple matter of...

There is already a test for checking the compression method handling with null compression. It would seem straightforward to modify the existing test to check the alert code: https://github.com/openssl/openssl/blob/6c39d21a4844cab997164454ece9b21186881f2a/test/recipes/70-test_comp.t#L65-L81

Here's an example of a test where we are looking for a particular alert code: https://github.com/openssl/openssl/blob/6c39d21a4844cab997164454ece9b21186881f2a/test/recipes/70-test_tls13hrr.t#L71-L82 https://github.com/openssl/openssl/blob/6c39d21a4844cab997164454ece9b21186881f2a/test/recipes/70-test_tls13hrr.t#L154-L161

Not sure why you closed this, but assuming you are planning on re-opening it at some point please note that we would require a test and updated documentation in order...

>It seems this is just waiting on a last minor https://github.com/openssl/openssl/pull/22980#discussion_r1429692315. given that this has sat idle for 250 days, is there any reason we can't just fix up the...

> Me myself I have no experience in contributing too such a big project that openssl ist :) Even though the code changes seem small enough I could probably even...

Fix for the above bug in #21723.

Another fix found by this in #21725