Matt Caswell

> @[samsonkolge](https://github.com/samsonkolge) samsonkolge requested a review from [mattcaswell](https://github.com/mattcaswell) [24 minutes ago](https://github.com/openssl/openssl/pull/27233#event-17129672292) I see you requested my review, but I don't see any new commits since my last review comments. Did...

Looks good. I will approve once @t8m's comments are addressed.

Pushed to master/3.5. Thank you for your contribution.

> I wonder what was the intent. My interpretation of this from looking at the code is that "no-shared no-static-engine" is supposed to build the library as no-shared, but still...

Pushed to master. Thanks for your contribution.

> Based on documentation caller could prepare any parameter type and to expect code to perform type conversion from string. Hmm. I don't see how you can interpret the bit...

I have to ask a more fundamental question. Why?? The stated purpose is: > This enables secure and efficient handling of fragmented or streaming data, which is critical for many...

So where is the spec that defines this encrypt-then-MAC operation, if is not the TLS one?

> @t8m is it acceptable to approve this to be run on the CI? Yes. In general just go for it if you are happy. But I've clicked approve anyway.

> how about a ! prefix for key_share, and ! suffix for HRR worthy groups Hmmm....that sounds *really* confusing. Let's not go down that route.