Mathieu Le Muzic

Results 18 comments of Mathieu Le Muzic

> @khanaffan thoughts? I checked with affan offline I'm going to try a different approach before resorting to rename in the repo

> > > > @aruniverse @pmconne do you know why would following test would fail on Mac only. Its not just PR its failing on others as well. > >...

> Did you run ImageTests with this option enabled? Some 3d models exist that TilesetPublisher intentionally never includes in its tileset. Primarily, 3d models used in drawings and sheets, but...

> Some 3d models exist that TilesetPublisher intentionally never includes in its tileset. Primarily, 3d models used in drawings and sheets, but technically any 3d model that is marked "private"...

> > @pmconne Does that mean that there is another fallback to V1 somewhere else? > > Yes, [here](https://github.com/iTwin/itwinjs-core/blob/18ddecdfdc6275bbf01585b49a4f066e9da0ac92/extensions/frontend-tiles/src/BatchedSpatialTileTreeRefs.ts#L32) for specific models not included in the batched tiles. I don't...

@pmconne all clear on the image tests front: https://[tilesetpublisher.z20.web.core.windows.net/index.html?account=tilesetpublisher&share=image-tests&cur=mlemuzic_implement_frontend_tiles_nop_fallback/f0853ff2e15e29e39bf747f25f455b3806f74477&ref=main/65432c7bb5fa80681dffa46d2fd091b3d539c7a4&se=2024-08-03&sp=rwl&sv=2022-11-02&ss=f&srt=co&sig=ePFZ/l%2BqeGMgFn1O9P2D2iEnK8xuiXvRLctqrTlpiak%3D](https://tilesetpublisher.z20.web.core.windows.net/index.html?account=tilesetpublisher&share=image-tests&cur=mlemuzic_implement_frontend_tiles_nop_fallback/f0853ff2e15e29e39bf747f25f455b3806f74477&ref=main/65432c7bb5fa80681dffa46d2fd091b3d539c7a4&se=2024-08-03&sp=rwl&sv=2022-11-02&ss=f&srt=co&sig=ePFZ/l%2BqeGMgFn1O9P2D2iEnK8xuiXvRLctqrTlpiak%3D)

@pmconne what do you think of this approach, is it viable? If yes, am I supposed to flush previous tile children / requests that I am replacing somehow?

@pmconne about consuming meshoptimizer module in parse IMDL workers... MeshoptCompression.decodeMeshoptBuffer is asynchronous, but there is currently no async logic in place in the parser, I could make all parent functions...