iTwin
Add optional nop fallback to frontend tiles and DPTA
Add optional Nop fallback to frontend tiles and DPTA so that we can catch tileset.json parsing errors earlier
We also exposed Nop fallback options to display test app test configuration options.
Did you run ImageTests with this option enabled? Some 3d models exist that TilesetPublisher intentionally never includes in its tileset. Primarily, 3d models used in drawings and sheets, but technically any 3d model that is marked "private" and/or is not spatially located. BatchedSpatialTileTreeReferences falls back to using V1 tiles for those models. At a glance, it looks like your "nopFallback" will cause nothing to render for those models. Is the assumption that none of the test cases you want to run using the no-op fallback will include such models?
Did you run ImageTests with this option enabled? Some 3d models exist that TilesetPublisher intentionally never includes in its tileset. Primarily, 3d models used in drawings and sheets, but technically any 3d model that is marked "private" and/or is not spatially located. BatchedSpatialTileTreeReferences falls back to using V1 tiles for those models. At a glance, it looks like your "nopFallback" will cause nothing to render for those models. Is the assumption that none of the test cases you want to run using the no-op fallback will include such models?
I will try it, but this nop option can be set for the whole test set, or for each single test, so in the worst case we can chose which tests shoud fallback to nop and which one to V1
Some 3d models exist that TilesetPublisher intentionally never includes in its tileset. Primarily, 3d models used in drawings and sheets, but technically any 3d model that is marked "private" and/or is not spatially located. BatchedSpatialTileTreeReferences falls back to using V1 tiles for those models.
@pmconne Does that mean that there is another fallback to V1 somewhere else ? at the moment it seems that I'm only falling back to V1 if the tileset json is missing or if there is deserialization issue when reading the file...
@pmconne Does that mean that there is another fallback to V1 somewhere else?
Yes, here for specific models not included in the batched tiles.
@pmconne Does that mean that there is another fallback to V1 somewhere else?
Yes, here for specific models not included in the batched tiles.
I don't think this will be covered by the Nop fallback, here we only want to make sure we don't want to publish an invalid tileset json (it happended already).
As long as there is a valid tileset json found, we will proceed as usual.
@pmconne all clear on the image tests front: https://tilesetpublisher.z20.web.core.windows.net/index.html?account=tilesetpublisher&share=image-tests&cur=mlemuzic_implement_frontend_tiles_nop_fallback/f0853ff2e15e29e39bf747f25f455b3806f74477&ref=main/65432c7bb5fa80681dffa46d2fd091b3d539c7a4&se=2024-08-03&sp=rwl&sv=2022-11-02&ss=f&srt=co&sig=ePFZ/l%2BqeGMgFn1O9P2D2iEnK8xuiXvRLctqrTlpiak%3D