Mathieu Benoit comments

Results 135 comments of


                                            Mathieu Benoit

trafficstars

Deploy and run the application on Cloud Run

Closing it for now like discussed, and leave it to you @NimJay and @xiangshen-dk to see what you want to do with the associated branch we will keep.

Update Java app `adservice` to `openjdk:17-slim`

The OT community bumped it to Java 18: https://github.com/open-telemetry/opentelemetry-demo/tree/main/src/adservice BOA moved to Java 17: https://github.com/GoogleCloudPlatform/bank-of-anthos/pull/712 Just sharing.

Update Java app `adservice` to `openjdk:17-slim`

Fixed by https://github.com/GoogleCloudPlatform/microservices-demo/pull/1007, with `openjdk:18` actually.

Consider separating service protos into different files

Good candidate to be tackle in https://github.com/GoogleCloudPlatform/microservices-demo/issues/814 too.

Tidy up (and document) `.proto` files

Could be great to consider this one in the meantime maybe? https://github.com/GoogleCloudPlatform/microservices-demo/issues/1

Tidy up (and document) `.proto` files

Thanks for sharing @mic-max, much appreciated!

Deprecate the use of Google Cloud Debugger

Is it something you could help with during one of your next rotations @arbrown or @minherz?

Update Python apps `emailservice`, `recommendationservice` and `loadgenerator` to `python:3.10-slim`

Bumped to Python 3.9 with PR #984. But still an issue with Python 3.10 like explained here: https://github.com/GoogleCloudPlatform/microservices-demo/pull/984#issuecomment-1232344995

build [cartservice] failed: exit status 1. Docker build ran into internal error. Please retry.

Hi @TonyChiangUSA, could you please give it a new try with the latest version of the `main` branch and tell us if you still have the issue? `cartservice` just got...

build [cartservice] failed: exit status 1. Docker build ran into internal error. Please retry.

Thanks for this information @TonyChiangUSA, reopening this issue for further investigation based on this. Could you confirm that you don't have anymore the issue with `cartservice` but now with `recommendationservice`?