microservices-demo icon indicating copy to clipboard operation
microservices-demo copied to clipboard

Deprecate the use of Google Cloud Debugger

Open bourgeoisor opened this issue 3 years ago • 3 comments
trafficstars

Since Cloud Debugger is getting deprecated (doc: https://cloud.google.com/debugger/docs), we should remove it altogether and potentially replace it with Snapshot Debugger (https://github.com/GoogleCloudPlatform/snapshot-debugger)

Cloud Debugger is currently embedded in some services (for example, https://github.com/GoogleCloudPlatform/microservices-demo/blob/main/src/recommendationservice/recommendation_server.py#L128)

Additionally, we should look into closing any potentially-no-longer-relevant issues, for example:

  • https://github.com/GoogleCloudPlatform/microservices-demo/issues/538
  • https://github.com/GoogleCloudPlatform/microservices-demo/issues/645
  • https://github.com/GoogleCloudPlatform/microservices-demo/issues/832

bourgeoisor avatar May 23 '22 22:05 bourgeoisor

Snapshot debugger only supports Node.js debug agent in preview mode still, looks like Python3 support will come eventually? That being said, are there any fixes we can provide for the above issues linked?

xtineskim avatar May 24 '22 13:05 xtineskim

potentially related https://github.com/GoogleCloudPlatform/microservices-demo/issues/713

xtineskim avatar May 24 '22 14:05 xtineskim

Is it something you could help with during one of your next rotations @arbrown or @minherz?

mathieu-benoit avatar Aug 31 '22 16:08 mathieu-benoit

Can we ensure that the cloud debugger replacement also has corresponding aarch64 support?

eti-tme-tim avatar Nov 01 '22 01:11 eti-tme-tim

we can try to look into it! for now docs are showing that Cloud debugger will be deprecated May 31, 2023 (https://cloud.google.com/debugger/docs/deprecations)

xtineskim avatar Nov 21 '22 15:11 xtineskim

Thanks, @xtineskim, for pointing out that the Snapshot Debugger will lose support after Aug 31, 2023:

Snapshot Debugger and associated agents will be supported until Aug 31, 2023, after which they will be archived and frozen.

In that case, I don't think we should use Snapshot Debugger at all. We should still remove all instances (inside Online Boutique) of Cloud Debugger being used.

NimJay avatar Nov 21 '22 15:11 NimJay