microservices-demo icon indicating copy to clipboard operation
microservices-demo copied to clipboard

Consider separating service protos into different files

Open ahmetb opened this issue 5 years ago • 4 comments

Currently all files are in a single proto. https://github.com/GoogleCloudPlatform/microservices-demo/blob/4572974c882b7c159a59e5344a3aa42c7f4af040/pb/demo.proto

Ideally we should have per-service protos like pb/hipstershop/currencyservice.proto etc.

ahmetb avatar Aug 03 '18 19:08 ahmetb

Closing this and other kind/improvement issues as we attempt to move the project into a stable maintenance state

daniel-sanche avatar Jan 16 '20 22:01 daniel-sanche

Reopening to resume the discussion and triage.

askmeegs avatar Nov 30 '21 19:11 askmeegs

Good candidate to be tackle in https://github.com/GoogleCloudPlatform/microservices-demo/issues/814 too.

mathieu-benoit avatar Jun 07 '22 11:06 mathieu-benoit

Commenting to cool this issue down (from our team's out-of-SLO list): We should still address this issue. I'll leave it open.

NimJay avatar Dec 07 '22 22:12 NimJay