Mat

Thanks, I need to push this PR to the finish line soon.

I know, I just feel very uncomfortable merging anything that touches user data unless I'm absolutely sure that no obvious bugs are present. Not so pleasant memories from wiping out...

Should be ready to go. I've refactored the code related to loading users.

> Anybody running master will be prudent enough to make backups of their user data. It is labelled as "unstable" after all! I wouldn't be so sure of that. I...

Fonts - we have options to set the global font and fonts for various parts of the UI. Is anything lacking here? Theme, colors, skins, background transparency - larger customizations...

> With the default N+ settings, on certain dark Gtk themes, the text color is invisible or inappropriate unless the customizations are used to workaround these broken themes. This is...

> When a user is banned the ban button should say unban instead, and remove him from the ban list when clicked. This is a good idea. Until it's implemented,...

This shouldn't be the case for downloads? The "User logged off" status isn't anywhere in the code at least: https://github.com/nicotine-plus/nicotine-plus/blob/0558c10b085fe5aba2991c2676d937f43a42676c/pynicotine/gtkgui/downloads.py#L169-L179 For uploads, the "Clear Finished" button in the bottom bar...

Here are the status combinations for uploads: https://github.com/nicotine-plus/nicotine-plus/blob/e70921a15442858744c3c1e7062fa05d6be4dbdf/pynicotine/gtkgui/uploads.py#L153-L164 I guess the main question is, do these combinations make sense? What would you expect here? The "Clear Finished" button currently calls...

> When we clear these uploads, I assume it's just on our end and those uploads aren't cancelled for the downloader Yes. > Or, if "User logged off" uploads were...